Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the aibrix installation scripts #141

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Sep 9, 2024

  • Correct the component name for e2e testing
  • Update some labels

Pull Request Description

  1. Add gateway dependency into the installation yamls
  2. Fix some errors during the integration

Related Issues

Resolves: #140

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

- Correct the component name for e2e testing
- Update some labels
@Jeffwan Jeffwan requested a review from varungup90 September 9, 2024 18:57
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Sep 9, 2024

image

kubectl apply -k config/default brings the prefix which make the gateway setting incorrect.


this has been fixed

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Sep 9, 2024

export ENVOY_SERVICE=$(kubectl get svc -n envoy-gateway-system --selector=gateway.envoyproxy.io/owning-gateway-namespace=aibrix-system,gateway.envoyproxy.io/owning-gateway-name=aibrix-eg -o jsonpath='{.items[0].metadata.name}')

kubectl -n envoy-gateway-system port-forward service/${ENVOY_SERVICE} 8888:80

invocation

curl --verbose --header "Host: www.example.com" http://localhost:8888/v1/models
* Host localhost:8888 was resolved.
* IPv6: ::1
* IPv4: 127.0.0.1
*   Trying [::1]:8888...
* Connected to localhost (::1) port 8888
> GET /v1/models HTTP/1.1
> Host: www.example.com
> User-Agent: curl/8.7.1
> Accept: */*
>
* Request completely sent off
< HTTP/1.1 404 Not Found
< date: Mon, 09 Sep 2024 21:51:33 GMT
< content-length: 0
<
* Connection #0 to host localhost left intact

@Jeffwan Jeffwan merged commit 1a09d47 into main Sep 9, 2024
3 checks passed
@Jeffwan Jeffwan deleted the jiaxin/gateway_installation_update branch September 9, 2024 22:00
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* Add gateway dependency in kustomize

- Correct the component name for e2e testing
- Update some labels

* Resolve the missing prefix configuration in gateway.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide stable installation and quick start tutorials
2 participants