Skip to content

Commit

Permalink
remove redundant isRayPodCreateOrDeleteFailed check
Browse files Browse the repository at this point in the history
Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com>
  • Loading branch information
Yicheng-Lu-llll committed Oct 13, 2024
1 parent d6a6732 commit dab3f11
Showing 1 changed file with 1 addition and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -124,13 +124,7 @@ func isClusterActive(c rayclusterv1.RayCluster) bool {
return true
}

// Case 3: The RayCluster has been provisioned, but Ray Pod creation or deletion failed afterward.
isRayPodCreateOrDeleteFailed := meta.IsStatusConditionPresentAndEqual(c.Status.Conditions, string(rayclusterv1.RayClusterReplicaFailure), metav1.ConditionTrue)
if isRayPodCreateOrDeleteFailed {
return false
}

// Case 4: The RayCluster has been provisioned and we need to check if it is ready.
// Case 3: The RayCluster has been provisioned and we need to check if it is ready.
// Currently, we consider any Ray Pod failure is unrecoverable and need to recreate a new RayCluster.
return rayclusterutil.IsRayClusterReady(&c)
}
Expand Down

0 comments on commit dab3f11

Please sign in to comment.