Skip to content

noise: implement 2d perlin noise (#42) #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 28, 2022
Merged

noise: implement 2d perlin noise (#42) #87

merged 8 commits into from
Jun 28, 2022

Conversation

boonsboos
Copy link
Contributor

saw there was an open issue, here you go

@boonsboos boonsboos changed the title noise: implement 2d perlin noise (partially #42) noise: implement 2d perlin noise (#42) Jun 26, 2022
ulises-jeremias
ulises-jeremias reviewed Jun 26, 2022
View reviewed changes
Copy link
Member

@ulises-jeremias ulises-jeremias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one small request! Also, could you add tests please? 👀

@boonsboos
Copy link
Contributor Author

i will do so tomorrow

@boonsboos
Copy link
Contributor Author

tests have been written, ready for merging!

@larpon larpon merged commit 3655c92 into vlang:master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulises-jeremias ulises-jeremias ulises-jeremias left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@boonsboos @ulises-jeremias @larpon @spytheman