checker: fix private symbol visibility checking #23543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Connected to Huly®: V_0.6-21971 |
|
V UI CI failures are fixed by vlang/ui#593 |
Need check `sum_type` and `function` also. And `function` type try to get the correct mod name.
|
Sorry for directly commit.... |
fix error "vlib/x/json2/decoder2/decode_sumtype.v:50:11: error: sum_type `Sum` was declared as private to module `main`, so it can not be used inside module `x.json2.decoder2`" Assume type define in `main` can be used as generic type in other module.
|
Already submitted a fix for Shy - larpon/shy#20 |
spytheman
reviewed
Jan 22, 2025
spytheman
reviewed
Jan 22, 2025
spytheman
reviewed
Jan 22, 2025
|
Submitted PR to herolib to fix visibility issue freeflowuniverse/herolib#30 |
|
If it can not be merged soon, we can just make |
|
The PR in herolib is now merged. I will merge this PR here as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #23518
Additional fixes:
larpon/shy#20
vlang/ui#593
vlang/ui#594