-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checker: check fn call argument mismatch (fix #23016) #23061
Conversation
Excellent work! |
@yuyi98, perhaps it should be a notice for a few weeks, then we can turn it to an error again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Hm, turning it into a notice will also affect the other conversions 🤔 . |
I'll fix msgpack first. |
I've fixed the failing compilations and pushed the changes where I could. I also made a PR to vcv88/discord.v#19 that fixes the remaining one. |
I should have used the link to this PR on the msgpack fix too 🤔 ... then github would have linked it too automatically here. |
The vtcc failure seems complex/time consuming to fix for me 🤔 . edit: I've pinged @felipensp about it on Discord. |
00c6e4b
to
7215d26
Compare
This PR check fn call argument mismatch (fix #23016).
Huly®: V_0.6-21501