Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v: add array.count #23054

Merged
merged 7 commits into from
Dec 3, 2024
Merged

v: add array.count #23054

merged 7 commits into from
Dec 3, 2024

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Dec 3, 2024 •
edited by huly-for-github bot
Loading

This PR implements builtin array.count() (including fixed array version).

Fix #23028

Huly®: V_0.6-21494

StunxFS
StunxFS approved these changes Dec 3, 2024
View reviewed changes
vlib/v/checker/fn.v Outdated Show resolved Hide resolved
spytheman
spytheman reviewed Dec 3, 2024
View reviewed changes
vlib/builtin/array.v Outdated Show resolved Hide resolved
@spytheman
Copy link
Member

spytheman commented Dec 3, 2024 •
edited
Loading

Excellent work. Please add a _test.v using the new method with arrays of different types, in vlib/v/tests/builtin_arrays/ too.

@felipensp felipensp marked this pull request as ready for review December 3, 2024 14:56
@spytheman spytheman merged commit 1eb3867 into vlang:master Dec 3, 2024
72 checks passed
@felipensp felipensp deleted the array_count_impl branch December 4, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

@StunxFS StunxFS StunxFS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add array.count
3 participants
@felipensp @spytheman @StunxFS