Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checker: fix mut var option unwrap with != none #22943

Merged
merged 6 commits into from
Nov 24, 2024
Merged

checker: fix mut var option unwrap with != none #22943

merged 6 commits into from
Nov 24, 2024

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Nov 23, 2024 •
edited by huly-for-github bot
Loading

@felipensp felipensp changed the title checker: fix option unwrap with != none checker: fix var option unwrap with != none Nov 23, 2024
@felipensp felipensp changed the title checker: fix var option unwrap with != none checker: fix mut var option unwrap with != none Nov 23, 2024
@felipensp felipensp marked this pull request as ready for review November 23, 2024 12:19
spytheman
spytheman approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit e86b526 into vlang:master Nov 24, 2024
71 of 72 checks passed
@felipensp felipensp deleted the fix_option_unwrap_mut branch November 24, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

checker error cannot access fields of an Option for if optval != none { where optval is muttable
2 participants
@felipensp @spytheman