Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/asn1: fix time creation to also accommodate negative timezone offsets #22861

Merged
merged 3 commits into from
Nov 16, 2024

Conversation

kimshrier
Copy link
Contributor

@kimshrier kimshrier commented Nov 14, 2024

When splitting the string representation of the time, the code did not previously allow for negative timezone offsets.

Huly®: V_0.6-21304

Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also add a test with a negative timezone?

@spytheman
Copy link
Member

There is no need to restore the TZ env variable - it is local to the _test.v program, and will not affect other programs, after it completes.

@spytheman spytheman merged commit 3009373 into vlang:master Nov 16, 2024
61 checks passed
@kimshrier
Copy link
Contributor Author

I wasn't sure if the TZ environment variable setting would have an adverse effect on other tests in time_test.v.

@kimshrier kimshrier deleted the fix_asn1_time_creation branch December 23, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants