Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checker: fix none check for match expr with option #22732

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Nov 2, 2024

@felipensp felipensp marked this pull request as ready for review November 2, 2024 10:52
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.


fn (p Post) get_part_2() string {
match p.part {
// Next weird line crashes compiler before sugesting 'unwrap' var?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That comment is part of the issue, but is fixed here; imho remove it, since it will be confusing for people in the future.

@spytheman spytheman merged commit 1937cdd into vlang:master Nov 2, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to match an option with none without unwrapping
3 participants