-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log,time: improve performance for writing a line to a log, add Time.format_rfc3339_micro/0 #22662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Write file in intervals should be good. like what happens here pub fn (mut pv Picoev) serve() {
spawn update_date_string(mut pv)
for {
pv.loop_once(1)
}
}
// update_date updates the date field of the Picoev instance every second for HTTP headers
fn update_date_string(mut pv Picoev) {
for {
// get GMT (UTC) time for the HTTP Date header
gmt := time.utc()
pv.date = gmt.http_header_string()
time.sleep(time.second)
}
}
|
spytheman
reviewed
Oct 26, 2024
This is good for a web server, but not as a general default. |
spytheman
changed the title
perf: log
log: improve performance for writing a line to the log
Oct 26, 2024
spytheman
changed the title
log: improve performance for writing a line to the log
log: improve performance for writing a line to a log
Oct 26, 2024
…lt format is checked first
spytheman
changed the title
log: improve performance for writing a line to a log
log,time: improve performance for writing a line to a log, add Time.format_rfc3339_micro/0
Oct 27, 2024
The musl CI jobs are failing due to an unrelated problem, that is fixed in #22667 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v wipe-cache && v -prod crun log_.v > lala.log
Before
After
*Note: if I remove time related format from log module
*Note2: This was just a quick tweak I discovered out of curiosity. I'm not interested in making any major improvements right now, but there are several other tweaks and tests, such as using safe-threads when have logpath defined to log without interfering with the application's performance, and reusing time variables in some cases and managing cache.
Huly®: V_0.6-21111