Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checker: optimise identical type checking #22596

Merged
merged 2 commits into from
Oct 21, 2024
Merged

checker: optimise identical type checking #22596

merged 2 commits into from
Oct 21, 2024

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Oct 20, 2024 •
edited by huly-for-github bot
Loading

@felipensp felipensp marked this pull request as ready for review October 20, 2024 12:30
@spytheman spytheman changed the title optimizing: immediate identical type checking checker: optimise identical type checking Oct 20, 2024
spytheman
spytheman approved these changes Oct 20, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

Can you please also add an early return for got_ and expected_ directly at the start of check_expected_call_arg ?

@felipensp
Copy link
Member Author

Excellent work.

Can you please also add an early return for got_ and expected_ directly at the start of check_expected_call_arg ?

yes, added.

@spytheman spytheman merged commit 9579c1f into vlang:master Oct 21, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felipensp @spytheman