-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v.scanner: use table lookups for very frequently done character checks #21931
v.scanner: use table lookups for very frequently done character checks #21931
Conversation
…ner.num_lit/2" This reverts commit 2cf06f4.
With gcc, the speedup is very modest (under 1%), and sometimes (rarely), the old version is slightly faster (i.e. it is on the margin for error on my machine). With tcc, the speedup is consistently around 1-2% for the scanner. |
Nice, good job! |
Great job! Hyperfine reports ~4% though, not 1-2%? |
Probably dependent on the hardware where you run it. CPU speed, memory speed, etc. can all affect code running speed. |
This has only the lookup changes from #21545 .
The substr_unsafe commit, turned out to be a problem.