orm: update readme with more specifics #21697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spytheman
reviewed
Jun 19, 2024
| @@ -47,23 +60,55 @@ struct Child { | |||
| } | |||
| ``` | |||
|
|
|||
| ### Create | |||
| To use the ORM, there is a special interface that lets you use the structs and V itself in queries. | |||
There was a problem hiding this comment.
Suggested change
| To use the ORM, there is a special interface that lets you use the structs and V itself in queries. | |
| To use the ORM, there is a special expression that lets you use the structs and V itself in queries. |
The word interface has a special meaning in V, and imho can be a bit confusing for the readers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on my project I found that time.Time has non-obvious behavior when creating tables in the ORM. Some additional specificity regarding passing the structs as the table was appreciated, and so the expression examples have been updated to be more explicit about this.
Some wording was updated as well to make concepts more obvious.
This PR only updates the README file in
vlib/orm, so no tests are necessary.