Allow losing unacknowledged packets

libs/client_lib/src/net.rs

@@ -234,7 +234,7 @@ pub fn send_network_updates(
     network_params
         .connection_state
         // Clients don't resend updates, so we can forget about unacknowledged packets.
-        .add_outcoming_packet_unchecked(time.frame_number, Instant::now());
+        .add_outcoming_packet(time.frame_number, Instant::now());
     let first_unacknowledged_frame = network_params
         .connection_state
         .first_unacknowledged_outcoming_packet()

libs/server_lib/src/net.rs

@@ -221,13 +221,7 @@ pub fn send_network_updates(
                 log::error!("Failed to send a message: {:?}", err);
             }
 
-            if let Err(err) =
-                connection_state.add_outcoming_packet(time.frame_number, Instant::now())
-            {
-                // TODO: disconnect players.
-                log::error!("Failed to add an outcoming packet: {:?}", err);
-                continue;
-            }
+            connection_state.add_outcoming_packet(time.frame_number, Instant::now());
         }
 
         // Broadcasting updates about new connected players.

libs/shared_lib/src/net.rs

@@ -106,22 +106,7 @@ impl ConnectionState {
             .map(|ack| ack.frame_number)
     }
 
-    pub fn add_outcoming_packet(
-        &mut self,
-        frame_number: FrameNumber,
-        sent: Instant,
-    ) -> Result<(), AddOutcomingPacketError> {
-        if self.outcoming_packets_acks.len() == 64 {
-            let oldest_packet = self.outcoming_packets_acks.front().unwrap();
-            if !oldest_packet.acknowledged {
-                return Err(AddOutcomingPacketError::WouldLoseUnacknowledged);
-            }
-        }
-        self.add_outcoming_packet_unchecked(frame_number, sent);
-        Ok(())
-    }
-
-    pub fn add_outcoming_packet_unchecked(&mut self, frame_number: FrameNumber, sent: Instant) {
+    pub fn add_outcoming_packet(&mut self, frame_number: FrameNumber, sent: Instant) {
         if self.outcoming_packets_acks.len() == 64 {
             self.outcoming_packets_acks.pop_front();
         }