This repository has been archived by the owner on Sep 1, 2020. It is now read-only.
export show/hideMenu methods in order to customize the trigger #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you fix the lint issues? |
|
Are you talking about the lint issues in the entire project?(semicolons ";" an "if" statements) |
|
Nope just the file you changed. It is missing an empty last line. |
|
ok, i'll fix that |
|
|
Done, it looks like everything is ok now |
vkbansal
approved these changes
Jul 20, 2017
Closed
|
Could anyone document this please? really appreciate it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encounter a problem on triggering the context menu from an element that is not a view itself so it cannot be the child of ContextMenuTrigger. In the JointJS framework, the cell elements are part of paper view, so in order to trigger the contextmenu on the cell elements i need to use the hideMenu and showMenu methods in the cell contexmenu event. Exposing these methods will make the triggering more customized and easier to adapt.