refactor: use the new NotificationFramework for pushing notifications #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes vjeantet#52 Replace `NSUserNotification` API with `UserNotifications.frameworks` API. * Import `UserNotifications/UserNotifications.h` in `alerter/AppDelegate.h` and `alerter/AppDelegate.m`. * Conform to `UNUserNotificationCenterDelegate` instead of `NSUserNotificationCenterDelegate` in `alerter/AppDelegate.h`. * Replace `NSUserNotification` with `UNNotificationRequest` for creating notifications in `alerter/AppDelegate.m`. * Replace `NSUserNotificationCenter` delegate methods with `UNUserNotificationCenter` delegate methods in `alerter/AppDelegate.m`. * Update methods to use `UNUserNotificationCenter` for managing notifications in `alerter/AppDelegate.m`. * Remove references to `NSUserNotification` in `alerter/main.m`.
|
What's the status of this PR? Is it ready to be merged? If I pull this down, can I build it and use it with the new MacOS notification API? What about code signing? Is that something I need to read up on? I've never have to deal with that before. |
|
@Tobbe Hi Tobbe; sorry for the late reply - should be good. No code-signing. |
|
No worries at all about the reply. Thanks for getting back to me 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52
Replace
NSUserNotificationAPI withUserNotifications.frameworksAPI.UserNotifications/UserNotifications.hinalerter/AppDelegate.handalerter/AppDelegate.m.UNUserNotificationCenterDelegateinstead ofNSUserNotificationCenterDelegateinalerter/AppDelegate.h.NSUserNotificationwithUNNotificationRequestfor creating notifications inalerter/AppDelegate.m.NSUserNotificationCenterdelegate methods withUNUserNotificationCenterdelegate methods inalerter/AppDelegate.m.UNUserNotificationCenterfor managing notifications inalerter/AppDelegate.m.NSUserNotificationinalerter/main.m.