Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted validation.n3 #3994

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

hauschke
Copy link
Member

@hauschke hauschke commented Jul 4, 2024

VIVO GitHub issue:

Other Relevant Links (Mailing list discussion, related pull requests, etc.):

What does this pull request do?

Deletes the file validation.n3 from the filegraph folder.

What's new?

  • Removes the file validation.n3

How should this be tested?

Additional Notes:

  • it should be double-checked if the deleted property and individuals are anywhere relevant in the code.

Interested parties

@VIVO-project/vivo-committers / VIVO Ontology IG (@melanieWacker @brianjlowe @annakasprzik etc.)

Reviewers' expertise

  1. Ontologies
  2. Reviewer needs an ORCID ID to test this

Reviewers' report template

Please update the following template which should be used by reviewers.

General comment

A reviewer should provide here comments and suggestions for requested changes if any.

Testing

A reviewer should briefly describe here how it was tested

Code reviewing

A reviewer should briefly describe here which part was code reviewed

Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing

I have only test to build VIVO and run VIVO and check error log. I didn't notice any error in the building process or while VIVO is running. I DIDN'T TEST INTEGRATION WITH ORCID.

Code reviewing

Code review is not needed for this PR, only testing

@brianjlowe brianjlowe merged commit 8ae97a6 into vivo-project:main Sep 24, 2024
4 checks passed
@chenejac chenejac linked an issue Nov 5, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove filegraph/validation.n3
3 participants