Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DialogContent from EditDialog #3401

Open
wants to merge 7 commits into
base: next
Choose a base branch
from
Open

Remove DialogContent from EditDialog #3401

wants to merge 7 commits into from

Conversation

juliawegmayr
Copy link
Contributor

@juliawegmayr juliawegmayr commented Feb 11, 2025 •
edited
Loading

Description

EditDialog has DialogContent hardcoded. But not all EditDialog should have it. Therefor it is removed.

Update script: vivid-planet/comet-upgrade#61

Acceptance criteria

Open TODOs/questions

  • Add changeset
  • Add description to migration guide

Further information

@juliawegmayr juliawegmayr changed the base branch from main to next February 11, 2025 13:17
@juliawegmayr juliawegmayr force-pushed the dialog-content-rendering branch from b9e560e to 5ae6e39 Compare February 11, 2025 13:47
@juliawegmayr juliawegmayr force-pushed the dialog-content-rendering branch from 5ae6e39 to 75cded2 Compare February 11, 2025 13:48
@juliawegmayr juliawegmayr self-assigned this Feb 13, 2025
@juliawegmayr juliawegmayr mentioned this pull request Feb 14, 2025
Draft
@juliawegmayr juliawegmayr marked this pull request as ready for review February 14, 2025 10:59
@auto-assign auto-assign bot requested a review from johnnyomair February 14, 2025 10:59
jamesricky
jamesricky reviewed Feb 19, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesricky jamesricky jamesricky approved these changes

@johnnyomair johnnyomair Awaiting requested review from johnnyomair

Assignees

@juliawegmayr juliawegmayr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliawegmayr @jamesricky @johnnyomair