Remove @comet/admin-react-select
#2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of @comet/admin-react-select
johnnyomair
reviewed
Dec 18, 2024
| "@comet/admin-react-select": major | ||
| --- | ||
|
|
||
| Remove `@comet/admin-react-select` package |
There was a problem hiding this comment.
I doubt it's possible to add a changeset for a then no longer existing package 🤔
There was a problem hiding this comment.
Maybe worth to try, i think it could work
| name="selectQuery" | ||
| label="Name" | ||
| component={FinalFormReactSelectStaticOptions} |
There was a problem hiding this comment.
Could we create an upgrade script that migrates from FinalFormReactSelectStaticOptions to AutocompleteField?
There was a problem hiding this comment.
We can try this, but i think it could get complicated 👍
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
@comet/admin-react-select
johnnyomair
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove @comet/admin-react-select
Screenshots/screencasts
Color Picker Story
Reset Filter Story
Further information