Remove Passport

[fraxachun]

Description

We decided to remove passport and use built in mechanism instead.

• Change naming scheme from Strategy to AuthService
• Simplify naming
  • AuthProxyJwtStrategy => JwtAuthService
  • StaticAuthedUserStrategy => StaticUserStrategy
  • StaticCredentialsBasicStrategy => BasicAuthService
• Use helper function createAuthGuardProviders to create providers (instead intransparent strategy-names)
• JwtAuthService uses @nestjs/jwt and is more flexible to cover different use cases
• Move creating the User object to AuthService (this is the correct place, not UserPermissionService or UserService)
• Use CometAuthGuard working without the need of a factory (makes it easier expandable)
• Let CometAuthGuard creates the CurrentUser-Object (instead AuthService, they're only for User)
• Export JwtModule from cms-api (has to be added to imports in auth.module.ts when JwtAuthService is used)

Open TODOs/questions

• Changeset
• Migration-Guide (or Upgrade-Script?)
• Caching of userService.getUser() in CometAuthGuard - separate PR
• Logging (especially for debug purposes) - separate PR
• Unit-Testing

Further information

https://vivid-planet.atlassian.net/browse/COM-1201

[johnnyomair]

Migration-Guide (or Upgrade-Script?)

A section in the migration guide is a must have IMO. If you want, you could also add an upgrade script. Though I believe it would be difficult to cover all usages across our projects.

[thomasdax98]

In some projects we use custom passport strategies, sometimes third-party, (e.g. https://www.npmjs.com/package/passport-headerapikey).
As far as I understand, this is still possible without passport in the library. Is this correct or could this cause problems?

[fraxachun]

A section in the migration guide is a must have IMO. If you want, you could also add an upgrade script. Though I believe it would be difficult to cover all usages across our projects.

84316fd

[fraxachun]

Passport is not supported anymore. But it should be easy adding a custom auth service.

Should we add a note regarding this to the migration guide?

7b66355

[fraxachun]

@johnnyomair Do we want this in v8? I would resolve the conflicts then so that you can merge it.

[johnnyomair]

@fraxachun I'd say yes. @thomasdax98 what do you think?

[thomasdax98]

@fraxachun I'd say yes. @thomasdax98 what do you think?

Yes, definitely

[fraxachun]

@johnnyomair Conflicts resolved