Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAM: Fix/set cache-control headers #2653

Merged
merged 2 commits into from
Oct 25, 2024
Merged

DAM: Fix/set cache-control headers #2653

merged 2 commits into from
Oct 25, 2024

Conversation

dkarnutsch
Copy link
Contributor

@dkarnutsch dkarnutsch commented Oct 22, 2024 •
edited
Loading

Description

Example

  • I have verified if my change requires an example

Screenshots/screencasts

Changeset

  • I have verified if my change requires a changeset

Related tasks and documents

Open TODOs/questions

Further information

@dkarnutsch dkarnutsch force-pushed the api/set-cache-headers branch from 4b56706 to 64e0a65 Compare October 24, 2024 05:21
@dkarnutsch
DAM: fix/set cache-control headers
9196bab 
public endpoints should cache files for 1 day
private endpoints should cache files for 1 year, but only in local caches

In the furture cache-control headers should not be stored alongside the file
@dkarnutsch dkarnutsch force-pushed the api/set-cache-headers branch from 64e0a65 to 9196bab Compare October 24, 2024 12:26
@dkarnutsch dkarnutsch changed the title Update cache headers DAM: Fix/set cache-control headers Oct 24, 2024
@dkarnutsch dkarnutsch marked this pull request as ready for review October 24, 2024 12:27
@auto-assign auto-assign bot requested a review from johnnyomair October 24, 2024 12:27
@dkarnutsch dkarnutsch added this to the v7.6.0 milestone Oct 24, 2024
@thomasdax98 thomasdax98 merged commit 6b0eceb into main Oct 25, 2024
11 checks passed
@thomasdax98 thomasdax98 deleted the api/set-cache-headers branch October 25, 2024 08:51
fichtnerma pushed a commit that referenced this pull request Nov 7, 2024
@dkarnutsch
DAM: Fix/set cache-control headers (#2653)
d582ef7
@johnnyomair johnnyomair mentioned this pull request Nov 21, 2024
Merged
johnnyomair added a commit that referenced this pull request Nov 21, 2024
@johnnyomair @dkarnutsch
DAM: Fix/set cache-control headers (v5) (#2801)
ec67253 
Backport of #2653 into v5.

Co-authored-by: Daniel Karnutsch <dkarnutsch@users.noreply.github.com>
thomasdax98 pushed a commit that referenced this pull request Nov 22, 2024
@dkarnutsch @thomasdax98
DAM: Fix/set cache-control headers (#2653)
8856f10
@thomasdax98 thomasdax98 mentioned this pull request Nov 22, 2024
Merged
@dkarnutsch dkarnutsch mentioned this pull request Feb 27, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasdax98 thomasdax98 thomasdax98 approved these changes

@johnnyomair johnnyomair johnnyomair approved these changes

Assignees

@dkarnutsch dkarnutsch

Labels
None yet
Projects
None yet
Milestone
v7.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dkarnutsch @thomasdax98 @johnnyomair