Demo Site Server: Convert to TypeScript #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsams
commented
Oct 5, 2024
| @@ -37,9 +36,9 @@ app.prepare() | |||
| res.statusCode = 500; | |||
| res.end("internal server error"); | |||
| } | |||
| }).listen(port, (err) => { | |||
| if (err) throw err; | |||
There was a problem hiding this comment.
This error handling I removed due to typing problems and here they also don't have it
67d81de to
e36634f
Compare
3 tasks
e36634f to
eaaddad
Compare
eaaddad to
ddb2253
Compare
dkarnutsch
requested changes
Oct 7, 2024
|
Can we convert admin/server/server.js as well? |
yes, we should convert that too. (But that is out of scope for this PR, feel free to create one) |
dkarnutsch
approved these changes
Oct 7, 2024
johnnyomair
approved these changes
Oct 7, 2024
johnnyomair
pushed a commit
to vivid-planet/comet-starter
that referenced
this pull request
Oct 15, 2024
Demo implementation: vivid-planet/comet#2595 and vivid-planet/comet#2617
fichtnerma
pushed a commit
that referenced
this pull request
Nov 3, 2024
Convert the custom server to TypeScript. This adds a compile step - as it is common for TypeScript. Based on https://github.com/vercel/next.js/tree/canary/examples/custom-server.
fichtnerma
pushed a commit
that referenced
this pull request
Nov 7, 2024
Convert the custom server to TypeScript. This adds a compile step - as it is common for TypeScript. Based on https://github.com/vercel/next.js/tree/canary/examples/custom-server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert the custom server to TypeScript. This adds a compile step – as it is common for TypeScript.
Based on https://github.com/vercel/next.js/tree/canary/examples/custom-server.
Open TODOs/questions