-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add phone and email link block #2142
Conversation
I remember we discussed if we need this or not, but that is years ago. We decided No back then. |
@nsams: @johnnyomair and @thomasdax98 decided that we should add these two blocks to the library. Meanwhile there are multiple implementations in many different repos around. So instead of add another copy to the comet-starter, we add it to the library and remove the other copies. The components itself are pretty common and can be used for every use case when they are needed. |
@nsams the problem with supporting |
@SebiVPS please rebase and resolve conflicts. |
0c58569
to
dd8545d
Compare
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
packages/api/blocks-api/src/blocks/validator/is-phone-number.validator.ts
Outdated
Show resolved
Hide resolved
Why are the blocks in |
@johnnyomair i put it there because there are more other blocks around in |
I'd say move it |
--------- Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com> Co-authored-by: Johannes Obermair <johannes.obermair@vivid-planet.com>
PR Checklist
Screenshots/screencasts