COM-394: Automatically generate className for component slots with createComponentSlot()
#1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1aaa82b to
149b3fa
Compare
All props previously passed are now inside the `ownerState` object, which is already prevented from being added to the DOM.
…not be present at all
The `size` prop was only intended to be used to control the padding, not to be passed to MUIs Button.
b17e883 to
f50f7d6
Compare
className for component slots when using createSlot
className for component slots when using createSlotclassName for component slots when using createSlot()
className for component slots when using createSlot()className for component slots with createSlot()
|
@johnnyomair FYI I'm not really sure how to fix the types in the lines with the However the usage of the |
johnnyomair
reviewed
Mar 13, 2024
docs/docs/comet-core-development/create-admin-components-with-theme-support.md
Outdated
Show resolved
Hide resolved
packages/admin/blocks-admin/src/blocks/common/AdminComponentButton.tsx
Outdated
Show resolved
Hide resolved
className for component slots with createSlot()className for component slots with createComponentSlot()
johnnyomair
reviewed
Mar 18, 2024
packages/admin/admin/src/common/toolbar/backbutton/ToolbarBackButton.tsx
Show resolved
Hide resolved
packages/admin/blocks-admin/src/blocks/common/AdminComponentButton.tsx
Outdated
Show resolved
Hide resolved
We should pair on this. I can't determine the errors by reading the code alone. 😁 |
johnnyomair
approved these changes
Mar 19, 2024
3a18e50
into
feature/refactor-admin-component-theming
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. the
Rootslot ofMainContentwill now alway the classNameCometAdminMainContent-root.If the
fullHeightprop is set to true, the classNameCometAdminMainContent-fullHeightalso will be added.This was previously done automatically, when using
withStyles()from the legacy@mui/stylespackage, which was removed during the theming refactor: #1376This now matches the behavior of Comet-Admin components before the theming refactor and MUI components.