CRUD Generator: Remove lastUpdatedAt argument from update mutations
#1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyomair
reviewed
Mar 7, 2024
lastUpdatedAt argument from update mutations
671eb3e to
2e947f9
Compare
|
@nsams could you please rebase this PR? |
This argument has the problem that it doesn't work well with multiple forms that are submitted together, eg. with two forms in tabs that get saved using a SaveBoundary. We decided to simply drop this argument.
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
693afc7 to
cae7bef
Compare
johnnyomair
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This argument has the problem that it doesn't work well with multiple forms that are submitted together, eg. with two forms in tabs that get saved using a SaveBoundary.
We decided to simply drop this argument.