Execute JSON.parse() twice to parse escaped JSON string in KubernetesService#getContentScope
#1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KubernetesService#getContentScope
johnnyomair
approved these changes
Feb 28, 2024
dkarnutsch
approved these changes
Feb 28, 2024
johnnyomair
pushed a commit
that referenced
this pull request
Oct 29, 2024
…sService#getContentScope` (#1778) Fix parsing of `contentScopeAnnotation` in `KubernetesService#getContentScope` --- You can see that only `json2` (after the second JSON.parse()) is an object <img width="572" alt="Bildschirmfoto 2024-02-28 um 15 14 47" src="https://github.com/vivid-planet/comet/assets/13380047/668b073e-226e-497b-a4f7-894a1372c016"> --- This bug is new in v6, but I don't know yet why it occurs now. This is a workaround so updating to v6 is possible for content websites. I'll still try to figure out the reason so maybe we can remove this again in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix parsing of
contentScopeAnnotationinKubernetesService#getContentScopeYou can see that only
json2(after the second JSON.parse()) is an objectThis bug is new in v6, but I don't know yet why it occurs now. This is a workaround so updating to v6 is possible for content websites. I'll still try to figure out the reason so maybe we can remove this again in the future.