Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COM-394: Refactor theming of remaining admin components and remove module augmentation of DefaultTheme #1758

Conversation

jamesricky
Copy link
Contributor

@jamesricky jamesricky commented Feb 27, 2024

Refactor theming of remaining admin-components

  • COM-487: FieldSet (Also added a dev-story)
  • COM-488: Alert
  • COM-489: DatePickerNavigation

Remove module augmentation of DefaultTheme type

As the @mui/styles package is no longer used for the styling-implementation of admin-components the DefaultTheme from @mui/styles/defaultTheme is no longer needed and would cause a typescript error when augmented.

@jamesricky jamesricky self-assigned this Feb 27, 2024
@jamesricky jamesricky changed the title COM-394: Refactor theming of remaining admin components Refactor theming of remaining admin components Feb 27, 2024
@jamesricky jamesricky changed the title Refactor theming of remaining admin components COM-394: Refactor theming of remaining admin components Feb 27, 2024
As the `@mui/styles` package is no longer used for the styling-
implementation of admin-components the `DefaultTheme` from
`@mui/styles/defaultTheme` is no longer needed and would cause a
typescript error when augmented.
@jamesricky jamesricky changed the title COM-394: Refactor theming of remaining admin components COM-394: Refactor theming of remaining admin components and remove module augmentation of DefaultTheme Feb 27, 2024
@johnnyomair johnnyomair merged commit 2a7bc76 into feature/refactor-admin-component-theming Feb 27, 2024
2 checks passed
@johnnyomair johnnyomair deleted the refactor-theming-of-remaining-admin-components branch February 27, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants