Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handmade form and grid for manufacturers #1751

Merged
merged 17 commits into from
Mar 26, 2024

Conversation

Ben-Ho
Copy link
Contributor

@Ben-Ho Ben-Ho commented Feb 26, 2024

this should showcase how to implement nested data in form and grid

missing

  • collapsing fieldset does not disable validation (required-validation) of fields => follow up pull-request
  • there are several options how to group fields, check if used correctly (found docs for FieldSection, should probably not be used in this usecase)
  • fieldset's are statically collapsed but should default-state should probably depend on wrapped fields containing data => follow up pull-request
  • probably there should be a case where collapsing set's some "address enabled"-field to keep data but disable usage => follow up pull-request

@Ben-Ho Ben-Ho requested review from nsams and johnnyomair February 26, 2024 09:59
@Ben-Ho Ben-Ho self-assigned this Feb 26, 2024
@nsams
Copy link
Member

nsams commented Feb 26, 2024

What is your plan for missing?

@Ben-Ho
Copy link
Contributor Author

Ben-Ho commented Feb 26, 2024

What is your plan for missing?

Discuss this topics with you and @johnnyomair, as I don't know if I'm using the correct components, or if some of them need improvements, and if we want to support the last point.

@johnnyomair johnnyomair mentioned this pull request Feb 29, 2024
6 tasks
@Ben-Ho Ben-Ho requested a review from johnnyomair February 29, 2024 13:11
@Ben-Ho Ben-Ho force-pushed the form-edit-nested-best-practice branch from 7d5a563 to 08590e4 Compare February 29, 2024 13:15
@Ben-Ho Ben-Ho requested a review from nsams February 29, 2024 14:28
@nsams
Copy link
Member

nsams commented Mar 5, 2024

@nsams what do you think of using filter in copyData?

in ProductsGrid we filter in copyData. And we type better.

We should not introduce too many changes here and address those in a separate PR.

@Ben-Ho Ben-Ho requested a review from nsams March 19, 2024 13:23
@Ben-Ho Ben-Ho requested a review from johnnyomair March 19, 2024 13:23
@Ben-Ho Ben-Ho requested review from nsams and johnnyomair March 25, 2024 13:27
@johnnyomair johnnyomair merged commit 6d659a9 into next Mar 26, 2024
10 checks passed
@johnnyomair johnnyomair deleted the form-edit-nested-best-practice branch March 26, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants