Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add hint to @comet/upgrade #1637

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Conversation

dkarnutsch
Copy link
Contributor

  • Add changeset (if necessary)

@nsams
Copy link
Member

nsams commented Jan 30, 2024

I would add the command in the migration guide everyone has to execute when upgrading. This is not optional.

And I would also remove all references in the migration guide to stuff that is done automatically with it. (We also have a changelog that should mention those renames)

the shorter the better

@johnnyomair
Copy link
Collaborator

And I would also remove all references in the migration guide to stuff that is done automatically with it. (We also have a changelog that should mention those renames)

Or we could do it similarly to how MUI does it:

image

https://mui.com/material-ui/migration/v5-component-changes/

@dkarnutsch dkarnutsch force-pushed the add-hint-for-upgrade-package branch from e737c27 to e3a772d Compare January 30, 2024 12:39
@dkarnutsch
Copy link
Contributor Author

@nsams like that?
Screenshot 2024-01-30 at 13 38 49

@nsams
Copy link
Member

nsams commented Jan 30, 2024

@nsams like that?

yes, but I would even see it as part of every single migration guide

@nsams
Copy link
Member

nsams commented Jan 30, 2024

the migration guide should be like a tutorial

@thomasdax98
Copy link
Member

yes, but I would even see it as part of every single migration guide
the migration guide should be like a tutorial

Yes, but IMO that doesn't mean we can't have some general information about the upgrade process in other parts of the docs. Also we don't have a direct reference to the comet-upgrade repo in the migration guide

@dkarnutsch
Copy link
Contributor Author

Yes, but IMO that doesn't mean we can't have some general information about the upgrade process in other parts of the docs. Also we don't have a direct reference to the comet-upgrade repo in the migration guide

That was my intention. So I think this PR is alright as it is as it addresses a different part.

@dkarnutsch dkarnutsch merged commit dbfc979 into main Jan 30, 2024
11 checks passed
@dkarnutsch dkarnutsch deleted the add-hint-for-upgrade-package branch January 30, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants