Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COM-291: Fix the type of the component prop on styled(Typography) #1616

Merged
merged 1 commit into from
Jan 31, 2024
Merged

COM-291: Fix the type of the component prop on styled(Typography) #1616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/admin/admin/src/appHeader/button/AppHeaderButton.styles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,4 +75,4 @@ export const Text = styled(Typography, {
overridesResolver(_, styles) {
return [styles.typography];
},
})();
})() as typeof Typography;
3 changes: 1 addition & 2 deletions packages/admin/admin/src/appHeader/button/AppHeaderButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export interface AppHeaderButtonProps
ThemedComponentBaseProps<{
root: typeof ButtonBase;
content: "div";
typography: typeof Typography;
typography: typeof Typography<"div">;
startIcon: "div";
endIcon: "div";
}> {
Expand All @@ -33,7 +33,6 @@ export function AppHeaderButton(inProps: AppHeaderButtonProps) {
(disableTypography ? (
children
) : (
// @ts-expect-error TODO
<Text component="div" {...slotProps?.typography}>
{children}
</Text>
Expand Down
Loading