COM-85: Refactor Theming of Picker Components #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before importing `@emotion/styled` the following typescript error would occur when defining some styled-components, e.g. `Root` in `packages/admin/admin-date-time/src/dateRangePicker/DateRangePicker.slots.ts`: ```error TS2742: The inferred type of 'Root' cannot be named without a reference to '.pnpm/@emotion+styled@11.10.5_@babel+core@7.20.12_@emotion+react@11.9.3_@types+react@17.0.53_react@17.0.2/node_modules/@emotion/styled'. This is likely not portable. A type annotation is necessary. ```
johnnyomair
reviewed
Dec 14, 2023
packages/admin/admin-color-picker/src/PreviewIndicatorColorProps.ts
Outdated
Show resolved
Hide resolved
Sorry, yes I agree. In this case it was a bit difficult, because they all used |
…ColorPicker.slots.ts`
johnnyomair
approved these changes
Jan 3, 2024
thomasdax98
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.