New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add `DamFileDownloadLinkBlock` #1228

Merged

johnnyomair merged 42 commits into main from add-dam-file-download

Jun 5, 2024

Contributor

F10Ragger commented Aug 14, 2023 •

edited by johnnyomair

Loading

Can be used to download a DAM file or open it in a new tab.

Bildschirmaufnahme.2023-11-15.um.23.55.03.mov

COM-563

F10Ragger requested a review from johnnyomair

August 14, 2023 08:21

F10Ragger self-assigned this

thomasdax98 changed the title ~~Dam file download~~ DamFileDownloadLinkBlock

F10Ragger force-pushed the add-dam-file-download branch from a29c898 to a6b30dc Compare

August 29, 2023 08:24

johnnyomair requested changes

View reviewed changes

packages/api/cms-api/src/page-tree/blocks/dam-file-download-link.block.ts Outdated Show resolved Hide resolved

packages/api/cms-api/src/page-tree/blocks/dam-file-download-link.block.ts Outdated Show resolved Hide resolved

packages/site/cms-site/package.json Outdated Show resolved Hide resolved

packages/site/cms-site/src/blocks/DamFileDownloadLinkBlock.tsx Outdated Show resolved Hide resolved

packages/admin/cms-admin/src/blocks/createDamFileDownloadLinkBlock.tsx Outdated Show resolved Hide resolved

demo/site/package.json Outdated Show resolved Hide resolved

F10Ragger force-pushed the add-dam-file-download branch from d8afdf2 to 40ad9be Compare

August 31, 2023 12:13

johnnyomair requested changes

View reviewed changes

Collaborator

johnnyomair left a comment

Could you please provide a screencast of the AdminComponent? Thanks!

packages/admin/cms-admin/src/blocks/DamFileDownloadLinkBlock.tsx Outdated Show resolved Hide resolved

packages/api/cms-api/src/page-tree/blocks/dam-file-download-link.block.ts Outdated Show resolved Hide resolved

packages/api/cms-api/src/page-tree/blocks/dam-file-download-link.block.ts Outdated Show resolved Hide resolved

packages/site/cms-site/src/blocks/DamFileDownloadLinkBlock.tsx Outdated Show resolved Hide resolved

packages/admin/cms-admin/src/blocks/DamFileDownloadLinkBlock.tsx Outdated Show resolved Hide resolved

F10Ragger force-pushed the add-dam-file-download branch from 1c68a80 to f29f263 Compare

November 15, 2023 23:26

nsams reviewed

View reviewed changes

packages/site/cms-site/src/blocks/DamFileDownloadLinkBlock.tsx Outdated Show resolved Hide resolved

johnnyomair requested changes

View reviewed changes

packages/api/cms-api/src/page-tree/blocks/dam-file-download-link.block.ts Outdated Show resolved Hide resolved

packages/api/cms-api/src/page-tree/blocks/dam-file-download-link.block.ts Outdated Show resolved Hide resolved

packages/site/cms-site/src/blocks/DamFileDownloadLinkBlock.tsx Outdated Show resolved Hide resolved

packages/site/cms-site/src/blocks/DamFileDownloadLinkBlock.tsx Outdated Show resolved Hide resolved

packages/site/cms-site/src/blocks/DamFileDownloadLinkBlock.tsx Outdated Show resolved Hide resolved

packages/admin/cms-admin/src/blocks/DamFileDownloadLinkBlock.tsx Outdated Show resolved Hide resolved

packages/admin/cms-admin/src/blocks/DamFileDownloadLinkBlock.tsx Outdated Show resolved Hide resolved

packages/admin/cms-admin/src/blocks/DamFileDownloadLinkBlock.tsx Outdated Show resolved Hide resolved

packages/api/cms-api/src/page-tree/blocks/dam-file-download-link.block.ts Outdated Show resolved Hide resolved

F10Ragger force-pushed the add-dam-file-download branch from f29f263 to ed38e99 Compare

December 10, 2023 22:02

Florian Ragger added 15 commits

December 11, 2023 00:34


          add DamFileDownload to api

b3f63e2


          add DamFileDownload to admin

82d89c4


          add DamFileDownload to site

104d0dd


          there should be an option to open the file in a new tab instead of do…

434952d

…wnloading it


          remove unncessary export

a2da5cd


          file-saver should be a dependency in cms-site

3718cf2


          remove unnecessare factory

212a0d7


          there is no need for tracking elements

381dcf9


          load dam path lazy in admin for performance reasons

eca0f34


          outsource generic messaga for easy reusability

f6fb033


          a divider at the end of the component is not needed

0de7a7d


          simplify code by using a tag instead of window.open() function

b775c28


          there is no need for cloning the element

9c63709


          there is no need to specify the enum

e618ed5


          use empty array if there is no file

56fe028

F10Ragger force-pushed the add-dam-file-download branch from 6b7e6d4 to 56fe028 Compare

December 10, 2023 23:38

Florian Ragger added 2 commits

December 11, 2023 18:38


          there is no need to clone the element

c96dccc


          add block-meta changes

d77d009

johnnyomair reviewed

View reviewed changes

packages/api/cms-api/src/dam/blocks/dam-file-download-link.block.ts Outdated Show resolved Hide resolved

johnnyomair self-requested a review

May 8, 2024 14:40

Florian Ragger added 3 commits

May 13, 2024 21:33


          extend changeset

da4532b


          fix formatted message

f2743b0


          implement previewUrls inside download service

3b70b8d

F10Ragger dismissed stale reviews from nsams, thomasdax98, and johnnyomair via

3b70b8d

May 13, 2024 20:00

johnnyomair reviewed

View reviewed changes

.changeset/green-years-drum.md Outdated Show resolved Hide resolved

packages/api/cms-api/src/dam/files/files.service.ts Show resolved Hide resolved

F10Ragger and others added 2 commits

May 14, 2024 11:31


          Use better changeset description

55306b8

Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>


          use seperate endpoint for web preview

06bf00f

johnnyomair reviewed

View reviewed changes

packages/api/cms-api/src/dam/files/files.controller.ts Outdated Show resolved Hide resolved

packages/api/cms-api/src/dam/files/files.controller.ts Outdated Show resolved Hide resolved

packages/api/cms-api/src/dam/files/files.controller.ts Outdated Show resolved Hide resolved


          update preview download endpoint

361125f

johnnyomair previously approved these changes

View reviewed changes

johnnyomair requested a review from nsams

May 15, 2024 08:31

Collaborator

johnnyomair commented May 15, 2024

LGTM. @nsams please review once again.

nsams reviewed

View reviewed changes

packages/site/cms-site/src/blocks/DamFileDownloadLinkBlock.tsx Show resolved Hide resolved

nsams reviewed

View reviewed changes

packages/api/cms-api/src/dam/files/files.service.ts Outdated Show resolved Hide resolved


          baseUrl should be the same as in createFileUrl

247818a

F10Ragger dismissed johnnyomair’s stale review via

247818a

May 20, 2024 21:55

johnnyomair requested a review from nsams

May 21, 2024 14:25

SebiVPS mentioned this pull request

Add call to action (and list) block vivid-planet/comet-starter#249

Merged

4 tasks

thomasdax98 self-requested a review

May 26, 2024 20:14

thomasdax98 approved these changes

View reviewed changes

thomasdax98 requested a review from johnnyomair

May 29, 2024 08:44

johnnyomair approved these changes

View reviewed changes

Collaborator

johnnyomair left a comment

LGTM, @nsams please review once more.

nsams approved these changes

View reviewed changes

johnnyomair merged commit 3ee8c7a into main

11 checks passed

johnnyomair deleted the add-dam-file-download branch

June 5, 2024 07:11

SebiVPS mentioned this pull request

Remove <a> tag from DamFileDownloadLinkBlock #2218

Merged

fichtnerma pushed a commit that referenced this pull request


          Add DamFileDownloadLinkBlock (#1228)

bceb0a1

Can be used to download a DAM file or open it in a new tab.

---------

Co-authored-by: Florian Ragger <florian.ragger@vivid-planet.com>
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet