Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use static rendering #732

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Use static rendering #732

merged 1 commit into from
Feb 18, 2025

Conversation

fraxachun
Copy link
Contributor

@fraxachun fraxachun commented Feb 14, 2025

See vivid-planet/comet#3318

Doesn't add createGraphQLFetchMiddleware since we don't use predefined pages in the starter (the only location which uses api request in the middleware).

Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge this once vivid-planet/comet#3318 has been merged.

@johnnyomair johnnyomair marked this pull request as draft February 17, 2025 12:43
@johnnyomair johnnyomair marked this pull request as ready for review February 18, 2025 08:41
@auto-assign auto-assign bot requested a review from johnnyomair February 18, 2025 08:41
@johnnyomair johnnyomair merged commit d75fa5a into main Feb 18, 2025
3 checks passed
@johnnyomair johnnyomair deleted the static-rendering2 branch February 18, 2025 08:41
@johnnyomair johnnyomair removed their request for review February 18, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants