Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unknown fragments in GraphQL documents validation #714

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

johnnyomair
Copy link
Collaborator

@johnnyomair johnnyomair commented Feb 6, 2025

Description

This prevents an error we noticed while upgrading GraphQL Codegen in Demo: The documents validation would fail for fragments coming from the library, e.g, FinalFormFileUpload. Ignoring the KnownFragmentNamesRule resolves the issue.

Further informatoin

@johnnyomair johnnyomair self-assigned this Feb 6, 2025
@thomasdax98 thomasdax98 merged commit 4b8dd97 into main Feb 18, 2025
3 checks passed
@thomasdax98 thomasdax98 deleted the graphql-codegen-unknown-fragments branch February 18, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants