Add not found page

[magdalenaxm]

---

PR Checklist

• Link to the respective task if one exists: COM-806
• Provide screenshots/screencasts if the change contains visual changes

Screenshots/screencasts

[johnnyomair]

Please change the base to main.

[nsams]

please use relative import

[thomasdax98]

af04bcc

[fraxachun]

Does this link always work? Because of this code in layout.tsx:

    if (!siteConfig.scope.languages.includes(language)) {
        notFound();
    }

[thomasdax98]

The layout uses the not found page of the layer above, so it falls back to the Next.js default:

We could also add an extra not found page for that. The problem is, we can't use FormattedMessage there because we have no IntlProvider since we don't know which language we are in.

Right now, we only have a not found page within the language scope. We could also add one for fallback which contains hardcoded English

[fraxachun]

Please consider #363 as additional context.

[johnnyomair]

@thomasdax98 what's the status here?

[thomasdax98]

@johnnyomair I simplified it once more. Now it's ready from my perspective

[johnnyomair]

It's odd that we need an additional component to fetch the header data for the non-internationalized not found page. Wouldn't it be better if the not found page fetched the header and passes it to the component, as we do in the layout?

[thomasdax98]

If I do that, I need to make the query in the not found page and in the layout. I wanted to avoid the code duplication, so I moved it to this shared component. I can't put it directly in the Header since it's a client component.

Would you prefer the code duplication?

[johnnyomair]

Would you prefer the code duplication?

I'm not sure. I'd prefer to have the solution that's the most easy to understand. It took me a while to understand your change.

Would it be possible to reuse the layout from /[domain]/[language]/layout.tsx in /[domain]/layout.tsx with a default language?

[nsams]

Moving (almost everything) from layout to Header might not be ideal: in real world applications the layout contains probably more than just a header, for example a footer.