Feature/ffmpeg #362
Open
Feature/ffmpeg #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yet support audio or image scaling.
Audio is not re-sampled, so it might come in a different format that expected, depending on source file
There was a problem hiding this comment.
I like it! A few thoughts:
- I'll let @sauterl comment on whether this works for long-running extractions
- We'll need to update the documentation to make sure people execute the appropriate task
|
Currently, there also isn't any explicit mechanism to select it in the config, so using it currently requires a code change. The responsible part of the config logic was recently adjusted anyway and I think there are still some issues with it. It might be worth discussing how much flexibility we want to expose in this case and what should just be handled using automatisms and 'reasonable defaults'. |
…sing FFMpegProcessVideoDecoder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added decoder based on external ffmpeg process. Tested and confirmed to be working with video, audio data might be unreliable depending on input due to lack of resampling. This might be helpful for extractions where no audio is needed and the decoder based on libffmpeg leaks memory.