Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vite-node): differentiate file url with hash and query #7365

Merged
merged 4 commits into from
Feb 3, 2025
Merged

fix(vite-node): differentiate file url with hash and query #7365

merged 4 commits into from
Feb 3, 2025

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Jan 27, 2025 •
edited
Loading

Description

I copied splitFileAndPostfix from Vite https://github.com/vitejs/vite/blob/2bea7cec4b7fddbd5f2fb6090a7eaf5ae7ca0f1b/packages/vite/src/shared/utils.ts#L36-L42. Vite uses this utility to put back a hash/query for asset urls for example.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify Netlify
Copy link

netlify bot commented Jan 27, 2025 •
edited
Loading

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 743177c
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67a01f0b6eb69b0008d21597
😎 Deploy Preview https://deploy-preview-7365--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa marked this pull request as ready for review January 27, 2025 04:00
Jason3S
Jason3S approved these changes Jan 27, 2025
View reviewed changes
Copy link

@Jason3S Jason3S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@hi-ogawa hi-ogawa merged commit 926ca95 into vitest-dev:main Feb 3, 2025
13 checks passed
@hi-ogawa hi-ogawa deleted the fix-file-url-hash-query-module-id branch February 3, 2025 01:57
renovate bot added a commit to mmkal/expect-type that referenced this pull request Feb 3, 2025
@renovate
chore(deps): update vitest monorepo to v3.0.5
0efdd0d 
##### [v3.0.5](https://github.com/vitest-dev/vitest/releases/tag/v3.0.5)

##### 🚀 Features

-   **ui**: Insert message "no tests found" in ui - by [@DevJoaoLopes](https://github.com/DevJoaoLopes) in vitest-dev/vitest#7366 [<samp>(92da4)</samp>](vitest-dev/vitest@92da490bd)

##### 🐞 Bug Fixes

-   Validate websocket request - by [@hi-ogawa](https://github.com/hi-ogawa) and [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7317 [<samp>(191ef)</samp>](vitest-dev/vitest@191ef9e34)
-   Don't toggle cli cursor on non-TTY - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7336 [<samp>(3c805)</samp>](vitest-dev/vitest@3c8050e69)
-   **vite-node**: Differentiate file url with hash and query - by [@hi-ogawa](https://github.com/hi-ogawa)  in vitest-dev/vitest#7365 [<samp>(926ca)</samp>](vitest-dev/vitest@926ca9546)

##### [View changes on GitHub](vitest-dev/vitest@v3.0.4...v3.0.5)
renovate bot added a commit to mmkal/expect-type that referenced this pull request Feb 9, 2025
@renovate
chore(deps): update vitest monorepo to v3.0.5
7b43cd5 
##### [v3.0.5](https://github.com/vitest-dev/vitest/releases/tag/v3.0.5)

This release includes security patches for:

-   [Remote Code Execution when accessing a malicious website while Vitest API server is listening | CVE-2025-24964](GHSA-9crc-q9x8-hgqq)

##### 🚀 Features

-   **ui**: Insert message "no tests found" in ui - by [@DevJoaoLopes](https://github.com/DevJoaoLopes) in vitest-dev/vitest#7366 [<samp>(92da4)</samp>](vitest-dev/vitest@92da490bd)

##### 🐞 Bug Fixes

-   Validate websocket request - by [@hi-ogawa](https://github.com/hi-ogawa) and [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7317 [<samp>(191ef)</samp>](vitest-dev/vitest@191ef9e34)
-   Don't toggle cli cursor on non-TTY - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7336 [<samp>(3c805)</samp>](vitest-dev/vitest@3c8050e69)
-   **vite-node**: Differentiate file url with hash and query - by [@hi-ogawa](https://github.com/hi-ogawa)  in vitest-dev/vitest#7365 [<samp>(926ca)</samp>](vitest-dev/vitest@926ca9546)

##### [View changes on GitHub](vitest-dev/vitest@v3.0.4...v3.0.5)
renovate bot added a commit to mmkal/expect-type that referenced this pull request Feb 12, 2025
@renovate
chore(deps): update vitest monorepo to v3.0.5
bb43607 
##### [v3.0.5](https://github.com/vitest-dev/vitest/releases/tag/v3.0.5)

This release includes security patches for:

-   [Remote Code Execution when accessing a malicious website while Vitest API server is listening | CVE-2025-24964](GHSA-9crc-q9x8-hgqq)

##### 🚀 Features

-   **ui**: Insert message "no tests found" in ui - by [@DevJoaoLopes](https://github.com/DevJoaoLopes) in vitest-dev/vitest#7366 [<samp>(92da4)</samp>](vitest-dev/vitest@92da490bd)

##### 🐞 Bug Fixes

-   Validate websocket request - by [@hi-ogawa](https://github.com/hi-ogawa) and [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7317 [<samp>(191ef)</samp>](vitest-dev/vitest@191ef9e34)
-   Don't toggle cli cursor on non-TTY - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7336 [<samp>(3c805)</samp>](vitest-dev/vitest@3c8050e69)
-   **vite-node**: Differentiate file url with hash and query - by [@hi-ogawa](https://github.com/hi-ogawa)  in vitest-dev/vitest#7365 [<samp>(926ca)</samp>](vitest-dev/vitest@926ca9546)

##### [View changes on GitHub](vitest-dev/vitest@v3.0.4...v3.0.5)
renovate bot added a commit to mmkal/expect-type that referenced this pull request Feb 12, 2025
@renovate
chore(deps): update vitest monorepo to v3.0.5
4f0deed 
##### [v3.0.5](https://github.com/vitest-dev/vitest/releases/tag/v3.0.5)

This release includes security patches for:

-   [Remote Code Execution when accessing a malicious website while Vitest API server is listening | CVE-2025-24964](GHSA-9crc-q9x8-hgqq)

##### 🚀 Features

-   **ui**: Insert message "no tests found" in ui - by [@DevJoaoLopes](https://github.com/DevJoaoLopes) in vitest-dev/vitest#7366 [<samp>(92da4)</samp>](vitest-dev/vitest@92da490bd)

##### 🐞 Bug Fixes

-   Validate websocket request - by [@hi-ogawa](https://github.com/hi-ogawa) and [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7317 [<samp>(191ef)</samp>](vitest-dev/vitest@191ef9e34)
-   Don't toggle cli cursor on non-TTY - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7336 [<samp>(3c805)</samp>](vitest-dev/vitest@3c8050e69)
-   **vite-node**: Differentiate file url with hash and query - by [@hi-ogawa](https://github.com/hi-ogawa)  in vitest-dev/vitest#7365 [<samp>(926ca)</samp>](vitest-dev/vitest@926ca9546)

##### [View changes on GitHub](vitest-dev/vitest@v3.0.4...v3.0.5)
@renovate renovate bot mentioned this pull request Feb 14, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jason3S Jason3S Jason3S approved these changes

@AriPerkkio AriPerkkio AriPerkkio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V3 breaks dynamic imports
3 participants
@hi-ogawa @Jason3S @AriPerkkio