Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typecheck): use unique temp and tsbuildinfo file for each tsconfig file (fix #7107) #7112

Merged
merged 1 commit into from
Dec 23, 2024
Merged

fix(typecheck): use unique temp and tsbuildinfo file for each tsconfig file (fix #7107) #7112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/vitest/src/typecheck/parse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,13 @@ export async function getTsconfig(root: string, config: TypecheckConfig) {
throw new Error('no tsconfig.json found')
}

const tsconfigName = basename(tsconfig.path, '.json')
const tempTsConfigName = `${tsconfigName}.vitest-temp.json`
const tempTsbuildinfoName = `${tsconfigName}.tmp.tsbuildinfo`

const tempConfigPath = join(
dirname(tsconfig.path),
'tsconfig.vitest-temp.json',
tempTsConfigName,
)

try {
Expand All @@ -88,15 +92,15 @@ export async function getTsconfig(root: string, config: TypecheckConfig) {
tmpTsConfig.compilerOptions.incremental = true
tmpTsConfig.compilerOptions.tsBuildInfoFile = join(
process.versions.pnp ? join(os.tmpdir(), 'vitest') : __dirname,
'tsconfig.tmp.tsbuildinfo',
tempTsbuildinfoName,
)

const tsconfigFinalContent = JSON.stringify(tmpTsConfig, null, 2)
await writeFile(tempConfigPath, tsconfigFinalContent)
return { path: tempConfigPath, config: tmpTsConfig }
}
catch (err) {
throw new Error('failed to write tsconfig.temp.json', { cause: err })
throw new Error(`failed to write ${tempTsConfigName}`, { cause: err })
}
}

Expand Down
2 changes: 1 addition & 1 deletion test/typescript/test/__snapshots__/runner.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ Vitest caught 1 unhandled error during the test run.
This might cause false positive tests. Resolve unhandled errors to make sure your tests are not affected.

⎯⎯⎯⎯⎯⎯ Typecheck Error ⎯⎯⎯⎯⎯⎯⎯
Error: error TS18003: No inputs were found in config file '<root>/tsconfig.vitest-temp.json'. Specified 'include' paths were '["src"]' and 'exclude' paths were '["**/dist/**"]'.
Error: error TS18003: No inputs were found in config file '<root>/tsconfig.empty.vitest-temp.json'. Specified 'include' paths were '["src"]' and 'exclude' paths were '["**/dist/**"]'.

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

Expand Down
Loading