Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cobradocs] synchronize with VStreamer Unit Tests: framework to remove the need to specify serialized strings in row events for unit tests (vitess#14903) #1693

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Feb 16, 2024

Description

This is an automated PR to synchronize the cobradocs with vitessio/vitess#14903

Copy link

netlify bot commented Feb 16, 2024

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 221e95d
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/65d3cd7cdcf1dd00082d883b
😎 Deploy Preview https://deploy-preview-1693--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines 92 to 96
-v vttestserver_data:/vt/vtdataroot/vitess \
vitess/vttestserver:mysql80
/vt/bin/vttestserver \
--alsologtostderr \
--data_dir=/vt/vtdataroot/ \
--data_dir=/vt/vtdataroot/vitess \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. The docs were changed in #1689 to reflect the real example snippet. I am investigating why the generated docs are generating this.

cc @ajm188

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking into this

@frouioui frouioui force-pushed the synchronize-cobradocs-for-14903 branch from 5de012a to d36eadf Compare February 19, 2024 21:36
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui merged commit bc80e23 into prod Feb 19, 2024
5 checks passed
@frouioui frouioui deleted the synchronize-cobradocs-for-14903 branch February 19, 2024 21:54
@shlomi-noach
Copy link
Contributor

This PR has overwritten changes made by #1690. It was created after #1690 was merged, so I'm not sure how this could happen.

@shlomi-noach
Copy link
Contributor

It has also overwritten #1688

@shlomi-noach shlomi-noach mentioned this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants