Replace all vtctlclient usage for vreplication commands #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
a0a68ef to
03eedea
Compare
frouioui
reviewed
Oct 11, 2023
| @@ -89,7 +89,6 @@ As a result, connection pools should be sized mindful of the capacity of the und | |||
| #### `--db_allprivs_user` | |||
|
|
|||
| * (default 'vt_allprivs') | |||
| * Created on demand by `vtctlclient ExecuteFetchAsAllPrivs` | |||
There was a problem hiding this comment.
Why are we not keeping this for vtctldclient,
There was a problem hiding this comment.
There's no ExecuteFetchAsAllPrivs vtctldclient command. I'm not sure that we need one either.
/cc @ajm188
There was a problem hiding this comment.
there's also no equivalent RPC for vtctld server. this was deliberate, as me, @deepthi and others agreed it was no longer needed
frouioui
reviewed
Oct 11, 2023
| @@ -31,7 +31,7 @@ All of the command options and parameters are listed in our [reference page for | |||
| Let's start by loading some sample data: | |||
|
|
|||
| ```bash | |||
| $ mysql < ../common/insert_commerce_data.sql | |||
There was a problem hiding this comment.
Should we remove the $ in all shell snippet?
There was a problem hiding this comment.
Not necessary, but the general standard (markdown linter e.g.) is that you do NOT include the prompt if the command is not run and thus the output not shown (but instead you're only showing the command that the reader should run). That's why I removed it here, as we do not include the command output.
03eedea to
da26e25
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
da26e25 to
da9b567
Compare
Those will have to be done separately Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
cef99d2 to
71ce78d
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
9a78349 to
51846fe
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
d1a02e7 to
9dc4e14
Compare
4 tasks
d516944 to
0c38eb2
Compare
0c38eb2 to
9970fad
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
deepthi
approved these changes
Oct 15, 2023
the Materialize, Mount, and Migrate commands are not documented yet. I will open a separate PR to rebuild the reference docs. Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
rohit-nayak-ps
approved these changes
Oct 16, 2023
2e19dfd to
84ccc40
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: vitessio/vitess#14206