Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate docs #1583

Merged
merged 5 commits into from
Sep 14, 2023
Merged

consolidate docs #1583

merged 5 commits into from
Sep 14, 2023

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Sep 13, 2023

@ajm188 ajm188 requested a review from deepthi September 13, 2023 11:50
@ajm188 ajm188 mentioned this pull request Sep 13, 2023
4 tasks
@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 707456b
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/650364d671d12e00087aa332
😎 Deploy Preview https://deploy-preview-1583--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: with this structure Hugo produces a > after each program in the left nav whether are not there are any sub-sections. There are additional docs for vtctl and vtctldclient but not for vtctld and vtorc. Could be misleading when people are just browsing docs.

Andrew Mason added 2 commits September 14, 2023 09:55
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
@ajm188 ajm188 force-pushed the andrew/consolidate-docs branch from e999b78 to 445e988 Compare September 14, 2023 13:55
Andrew Mason added 3 commits September 14, 2023 09:58
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
this makes it so we only expand if there are actual "regular pages" (i.e. not just `_index.md`) in a section

Signed-off-by: Andrew Mason <andrew@planetscale.com>
@ajm188
Copy link
Contributor Author

ajm188 commented Sep 14, 2023

okay, i think 707456b fixes it. i tested in on the #1582 and it had expanders only for mysqlctl, vtctl, and vtctldclient and none of the others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants