Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtorc cobra docs #1576

Merged
merged 4 commits into from
Sep 6, 2023
Merged

vtorc cobra docs #1576

merged 4 commits into from
Sep 6, 2023

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Sep 5, 2023

docs for vitessio/vitess#13917, plus a refactor to make it better

Andrew Mason added 3 commits September 5, 2023 15:12
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 58bfd91
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/64f86d2ab9258700083bd1a1
😎 Deploy Preview https://deploy-preview-1576--vitess.netlify.app/docs/18.0/reference/programs/vtorc
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines 22 to 23
--config string config file name
-h, --help help for vtorc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can --config and --help description texts start with a capital letter like the other flags?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--config can (requires a change to vitessio/vitess), but --help comes from cobra and cannot

Signed-off-by: Andrew Mason <andrew@planetscale.com>
@frouioui frouioui merged commit 553a9ce into prod Sep 6, 2023
@frouioui frouioui deleted the andrew/vtorc-cobra-doc branch September 6, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants