Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

content/en/docs/18.0: rework vtbackup DurationByPhase into binary valued Phase #1452

Merged
merged 1 commit into from
Aug 2, 2023
Merged

content/en/docs/18.0: rework vtbackup DurationByPhase into binary valued Phase #1452

merged 1 commit into from
Aug 2, 2023

Conversation

maxenglander
Copy link
Collaborator

@maxenglander maxenglander mentioned this pull request Apr 25, 2023
Merged
4 tasks
@netlify
Copy link

netlify bot commented Apr 25, 2023 •
edited
Loading

✅ Deploy Preview for vitess ready!

Name Link
🔨 Latest commit f3769a3
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/64920c3b40151a00087a9be3
😎 Deploy Preview https://deploy-preview-1452--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@maxenglander maxenglander marked this pull request as ready for review April 26, 2023 12:21
deepthi
deepthi approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll wait to merge this until the linked code PR is merged.

deepthi
deepthi previously requested changes Jun 20, 2023
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxenglander since this isn't going into v17, can you move the changes to v18 of the docs?

@maxenglander
content/en/docs/18.0: rework vtbackup DurationByPhase into binary val…
f3769a3 
…ued Phase

Signed-off-by: Max Englander <max@planetscale.com>
@maxenglander maxenglander force-pushed the maxeng-rework-vtb-phase-stats branch from 9e44842 to f3769a3 Compare June 20, 2023 20:29
@maxenglander maxenglander changed the title content/en/docs/17.0: rework vtbackup DurationByPhase into binary valued Phase content/en/docs/18.0: rework vtbackup DurationByPhase into binary valued Phase Jun 20, 2023
@maxenglander
Copy link
Collaborator Author

Thanks @deepthi I've updated this PR as well as the changelog in vitessio/vitess#12973

@maxenglander maxenglander requested a review from deepthi June 20, 2023 20:49
@shlomi-noach shlomi-noach dismissed deepthi’s stale review August 2, 2023 06:07

requested changes were made

@shlomi-noach
Copy link
Contributor

Requested changes were made. Merging.

@shlomi-noach shlomi-noach merged commit 62df8c7 into prod Aug 2, 2023
@shlomi-noach shlomi-noach deleted the maxeng-rework-vtb-phase-stats branch August 2, 2023 06:07
shlomi-noach added a commit that referenced this pull request Aug 2, 2023
@shlomi-noach
Revert "content/en/docs/18.0: rework vtbackup DurationByPhase into bi…
c782ea6 
…nary valued Phase (#1452)"

This reverts commit 62df8c7.
This was referenced Aug 2, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@deepthi deepthi Awaiting requested review from deepthi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxenglander @shlomi-noach @deepthi