[vtctl/workflow] More trafficswitcher extraction #9007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b4e26a to
8f3d68f
Compare
…r+wrangler This will make the eventual move of trafficswitcher into `package workflow` simpler and smaller in scope Signed-off-by: Andrew Mason <amason@slack-corp.com>
This should only be temporarily exported Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
… cleanup Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
8f3d68f to
846f83f
Compare
deepthi
approved these changes
Oct 19, 2021
| @@ -773,7 +773,7 @@ func (df *vdiff) syncTargets(ctx context.Context, filteredReplicationWaitTime ti | |||
| } | |||
|
|
|||
| err = df.forAll(df.targets, func(shard string, target *shardStreamer) error { | |||
| pos, err := df.ts.wr.tmc.MasterPosition(ctx, target.primary.Tablet) | |||
| pos, err := df.ts.TabletManagerClient().PrimaryPosition(ctx, target.primary.Tablet) | |||
There was a problem hiding this comment.
Should be fine since this will only go into 13.0 and we introduce PrimaryPosition in 12.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR continues to move things from wrangler.trafficSwitcher into the interface type in vtctl/workflow. The goal here is to make
git grep -E "ts\.[a-z]" -- go/vt/wranglerempty (wheretsis a trafficSwitcher, not a topo.Server 😅 ); in other words to have wrangler's use of traffic switcher be "public functions/fields only"; at that point we can cut-paste the trafficSwitcher frompackage wranglertopackage workflowin a single, easy-to-review change. Then we can begin peeling off the vdiff code to be used in the newgrpcvtctldserverI also cleaned up some references to
MasterPositionwhile I was here.Related Issue(s)
#7931
Checklist
Deployment Notes