Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reparentutil | ERS] Bind status variable to each goroutine in WaitForRelayLogsToApply #7692

Merged
merged 1 commit into from
Mar 16, 2021
Merged

[reparentutil | ERS] Bind status variable to each goroutine in WaitForRelayLogsToApply #7692

merged 1 commit into from
Mar 16, 2021

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Mar 16, 2021 •
edited by deepthi
Loading

Closes #7691.

Signed-off-by: Andrew Mason amason@slack-corp.com

Description

Pretty much what it says in the issue description. We're binding that status variable on each iteration to the goroutine we're spawning to prevent potentially telling tablet A to wait for tablet B's StopPosition.

Related Issue(s)

Checklist

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

@ajm188
[reparentutil | ERS] Bind status variable to each goroutine in WaitFo…
20658c6 
…rRelayLogsToApply

Closes vitessio#7691.

Signed-off-by: Andrew Mason <amason@slack-corp.com>
setassociative
setassociative approved these changes Mar 16, 2021
View reviewed changes
Copy link

@setassociative setassociative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@deepthi deepthi added this to the v10.0 milestone Mar 16, 2021
deepthi
deepthi approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthi
Copy link
Member

deepthi commented Mar 16, 2021

10.0 isn't out yet, so no backport is required.

@deepthi deepthi merged commit 5feb957 into vitessio:master Mar 16, 2021
@ajm188 ajm188 deleted the am_ers_bind_status_variable branch May 29, 2021 10:25
@ajm188 ajm188 mentioned this pull request Jul 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@setassociative setassociative setassociative approved these changes

@askdba askdba Awaiting requested review from askdba

Assignees
No one assigned
Labels
Component: Cluster management Type: Bug
Projects
None yet
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.

[reparentutil | ERS] Unbound variable referenced in closure in loop
4 participants
@ajm188 @deepthi @setassociative @askdba