Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for SHOW TABLE STATUS queries. #6807

Merged
merged 11 commits into from
Oct 7, 2020
Merged

Added support for SHOW TABLE STATUS queries. #6807

merged 11 commits into from
Oct 7, 2020

Conversation

GuptaManan100
Copy link
Member

Added support for SHOW TABLE STATUS queries. Fixes #6354

@GuptaManan100
Added a new struct for SHOW TABLE STATUS
0160cc9 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Added query builder function for ShowTableStatus but keyspaceName nee…
8863e99 
…ds to be handled

Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Removed from ks name from the Format of ShowTableStatus
e88ad4b 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Revert "Removed from ks name from the Format of ShowTableStatus"
0ca8a48 
This reverts commit e88ad4b.

Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Removed databasename before sending the query via Send and Added test…
a87c40d 
… cases

Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Merged master
c435dc2 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Resolved error in sql.go by creating again
e1bac58 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Resolved make parser check
149ea24 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Merged Master
fdf2462 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
harshit-gangal
harshit-gangal requested changes Oct 6, 2020
View reviewed changes
Copy link
Member

@harshit-gangal harshit-gangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ShowTableStatus is new ast struct and therefore need to be added in vttablet planning.

@GuptaManan100
Added planning support for Show table status on vttablet
d63cd7d 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Merged master
da1174b 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
harshit-gangal
harshit-gangal approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@harshit-gangal harshit-gangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be taken care in #6825

@harshit-gangal harshit-gangal merged commit 0988455 into vitessio:master Oct 7, 2020
@setassociative setassociative mentioned this pull request Mar 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@systay systay Awaiting requested review from systay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support SHOW TABLE STATUS FROM db type queries in vtgate
2 participants
@GuptaManan100 @harshit-gangal