build: remove chromium hard-coding #6636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That version isn't supported any more. Hopefully, whatever problem the default version had is fixed by now. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
rohit-nayak-ps
approved these changes
Aug 28, 2020
There was a problem hiding this comment.
Not certain, but I don't think should should cause any issue.
(In any case the app does not work for me on Chrome but does on the Chromium browser because one of the packages used uses an old API. I had fixed the generated files directly to make it work with the newer Chromes, but with the new build system that hack was lost. )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That version isn't supported any more. Hopefully, whatever problem
the default version had is fixed by now.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com