Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VReplication and vstreamer metrics #6519

Merged
merged 4 commits into from
Aug 2, 2020
Merged

VReplication and vstreamer metrics #6519

merged 4 commits into from
Aug 2, 2020

Conversation

rohit-nayak-ps
Copy link
Contributor

No description provided.

@rohit-nayak-ps
Vrepl Metrics: added initial set of metrics to vreplication streams
b5002a2 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
VRepl Metrics: added vstreamer stats, tests for vr/vs, updated vr stats
d4f632e 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Vrepl Metrics: improvements, more tests
5c7ef2c 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Vrepl Metrics: vr query timings, vs phase timings
37dc771 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review August 1, 2020 20:02
@rohit-nayak-ps rohit-nayak-ps requested a review from sougou as a code owner August 1, 2020 20:02
sougou
sougou approved these changes Aug 2, 2020
View reviewed changes
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to tell if these metrics are too much or too little. Only time will tell. We can fix forward as needed.

@sougou sougou merged commit 99783bc into vitessio:master Aug 2, 2020
@ameetkotian ameetkotian mentioned this pull request Aug 20, 2020
Merged
@askdba askdba added this to the v8.0 milestone Oct 5, 2020
@setassociative setassociative mentioned this pull request Mar 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sougou sougou sougou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rohit-nayak-ps @sougou @askdba