Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert syslog events to normal log events #6511

Merged
merged 1 commit into from
Aug 2, 2020
Merged

Convert syslog events to normal log events #6511

merged 1 commit into from
Aug 2, 2020

Conversation

aquarapid
Copy link
Contributor

@aquarapid aquarapid commented Jul 31, 2020 •
edited by deepthi
Loading

if the syslog daemon cannot be contacted.

Signed-off-by: Jacques Grove aquarapid@gmail.com

@aquarapid
Address vitessio#3563 by converting syslog events to normal log event…
83d3853 
…s if the

syslog daemon cannot be contacted.

Signed-off-by: Jacques Grove <aquarapid@gmail.com>
@aquarapid aquarapid requested review from sougou and derekperkins July 31, 2020 00:22
@deepthi deepthi changed the title Address #3563 by converting syslog events to normal log events if the Convert syslog events to normal log events if the Jul 31, 2020
@deepthi deepthi changed the title Convert syslog events to normal log events if the Convert syslog events to normal log events Jul 31, 2020
deepthi
deepthi reviewed Jul 31, 2020
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume you have tested this locally and verified the result. Let's wait and see if others have an opinion.

@sougou sougou merged commit 273bc96 into vitessio:master Aug 2, 2020
@aquarapid aquarapid mentioned this pull request Aug 10, 2020
Closed
@ameetkotian ameetkotian mentioned this pull request Aug 20, 2020
Merged
@askdba askdba added this to the v8.0 milestone Oct 5, 2020
@setassociative setassociative mentioned this pull request Mar 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi left review comments

@sougou sougou sougou approved these changes

@derekperkins derekperkins Awaiting requested review from derekperkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@aquarapid @deepthi @sougou @askdba