Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more system settings #6486

Merged
merged 2 commits into from
Jul 28, 2020

Conversation

systay
Copy link
Collaborator

@systay systay commented Jul 28, 2020

Building on the experimental SET support for session system settings added in #6459:
System variables have been put into four different buckets:

  • Ignore These settings are accepted and ignored
  • Error Attempting to SET these will always result in an error
  • CheckAndIgnore For these settings, Vitess will accept the SET statement only when the value matches what is already configured globally.
  • UseReserveConn This is the exciting new feature we’ve added - if these settings are changed, a dedicated connection will be used to the underlying database.

Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay requested a review from sougou as a code owner July 28, 2020 06:18
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal merged commit cb7bb48 into vitessio:master Jul 28, 2020
@systay systay mentioned this pull request Jul 28, 2020
@deepthi deepthi added this to the v8.0 milestone Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants